Skip to content

Conversation

@jmagak
Copy link
Member

@jmagak jmagak commented Feb 4, 2025

IMPORTANT: Do Not Merge - To be merged by Docs Team Only

Version(s): 1.3, 1.4

Add the relevant labels to the Pull Request.
Issue: https://issues.redhat.com/browse/RHIDP-1848

Preview: Configuring guest access with RBAC UI

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Feb 4, 2025

@jmagak jmagak marked this pull request as ready for review February 4, 2025 19:04
@jmagak jmagak force-pushed the RHIDP-1848-Add-instructions-for-setting-up-RBAC-perms-and-authentication-for-Guest-users branch from 184c12b to 5d04431 Compare February 4, 2025 19:40
Copy link
Member

@linfraze linfraze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments and suggestions <3

Copy link
Member

@PatAKnight PatAKnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 6, 2025
@jmagak jmagak added Technical review done ⛅ Any procedure has been succesfully tested and removed Technical review needed 🔩 Test all the procedures labels Feb 6, 2025
@themr0c themr0c removed the lgtm label Feb 17, 2025
Copy link
Member

@linfraze linfraze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few considerations

@jmagak jmagak force-pushed the RHIDP-1848-Add-instructions-for-setting-up-RBAC-perms-and-authentication-for-Guest-users branch from a91e3c3 to ef6eac1 Compare February 19, 2025 15:38
@jmagak jmagak requested a review from linfraze February 19, 2025 18:20
Copy link
Member

@linfraze linfraze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just applied some fixes that the Vale linter caught, but lgtm

@jmagak
Copy link
Member Author

jmagak commented Feb 25, 2025

@linfraze, I made slight adjustments to the text. Let me know what you think.

@jmagak jmagak changed the title Updates the setting up RBAC permission RHIDP-1848: Updates the setting up RBAC permission Feb 25, 2025
@hmanwani-rh hmanwani-rh merged commit 1f1ccc2 into redhat-developer:main Feb 28, 2025
3 checks passed
@hmanwani-rh
Copy link
Member

/cherry-pick release-1.4

@hmanwani-rh
Copy link
Member

/cherry-pick release 1.5

@hmanwani-rh
Copy link
Member

/cherry-pick release-1.3

@openshift-cherrypick-robot
Copy link
Contributor

@hmanwani-rh: new pull request created: #964

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Contributor

@hmanwani-rh: cannot checkout release: error checking out "release": exit status 1 error: pathspec 'release' did not match any file(s) known to git

In response to this:

/cherry-pick release 1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Contributor

@hmanwani-rh: new pull request created: #965

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hmanwani-rh
Copy link
Member

/cherry-pick release-1.5

@openshift-cherrypick-robot
Copy link
Contributor

@hmanwani-rh: new pull request created: #966

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants